PX4 Sync / Q&A: Sep 11, 2024

gillamkid · September 11, 2024, 3:23pm

I have a few PRs for QGC I would like to bring to attention to so I can get them pushed along

Custom Windows Icons

github.com/mavlink/qgroundcontrol

Custom Windows Icons

mavlink:master ← gillamkid:gillamkid/windows-custom-icons

opened 02:50PM - 11 Sep 24 UTC

gillamkid

+49 -7

# Description This PR does 2 things 1. Fixes custom-example (currently broken …if you try to run it out of the box) 2. Make QGC Windows icons customizable ## Sponsor This contribution was sponsored by [Firestorm](https://www.launchfirestorm.com/) ![654d4f9476ff2a38f37e9ab9_firestorm-homepage-share-img-2](https://github.com/user-attachments/assets/bc1a2c95-b33d-4a2d-af35-4d2d8651d0a2) ## fix 1 - Fix custom-build (update using updateqrc.py) updateqrc.py should be run from the custom-example folder everytime qgcresources.qrc in the root directory gets changed. This was missed the last time qgcresources.qrc was updated so the custom-example failed to build out of the box ## fix 2 - Make QGC Windows icons customizable The QGC icon inside the app was already replaceable via the custom folder, however the QGC icon that was displayed on the Windows app bar, Windows installer, and windows shortcut icons was not able to be customized from the custom folder. This PR adds that capability. installer screen shots before/after (both screenshots are installing a custom variant of QGC, ie. the custom-example variant) ![before-install-window](https://github.com/user-attachments/assets/a8060167-3c3f-4970-b3d6-6b9642cb5bae) ![after-install-window](https://github.com/user-attachments/assets/50501c02-82e8-4602-8ee1-4989ae707da3) shortcut icons before/after (all shortcuts shown are goint to a custom variant of QGC, ie. the custom-example variant) ![before-shortcut-icon](https://github.com/user-attachments/assets/13159d2a-e72a-42f6-b6ce-65a0d26d2e64) ![after-shortcut-icon](https://github.com/user-attachments/assets/662492fe-3f3b-41c8-9018-6914bed1ebaf)

Custom Linux Icons

github.com/mavlink/qgroundcontrol

Custom Linux icons

mavlink:master ← gillamkid:gillamkid/custom-qgc-linux-icon

opened 06:39PM - 07 Sep 24 UTC

gillamkid

+17 -8

# Description QGC already allows in-app QGC icons to be replaced with a custom …variant in the custom folder. This PR makes so desktop app icons shown in Linux are also the custom variant. ## Sponsor This contribution was sponsored by [Firestorm](https://www.launchfirestorm.com/) ![654d4f9476ff2a38f37e9ab9_firestorm-homepage-share-img-2](https://github.com/user-attachments/assets/bc1a2c95-b33d-4a2d-af35-4d2d8651d0a2) ## Before/After pics ![before-linux-app-icon](https://github.com/user-attachments/assets/10c8b9e1-1f07-4556-b4bc-0ce3223a4807) ![after-linux-app-icon](https://github.com/user-attachments/assets/f3dbe0b9-ac47-4707-aca9-1d5ea5b6deb8)

Sizing Fixes (buttons, popups, etc)

github.com/mavlink/qgroundcontrol

Sizing Fixes (buttons, popups, etc)

mavlink:master ← gillamkid:gillamkid/sizing-fixes

opened 01:20PM - 07 Sep 24 UTC

gillamkid

+24 -13

# Description Fixes a couple sizing bugs and makes button sizing/spacing look b…etter ## Sponsor This contribution was sponsored by [Firestorm](https://www.launchfirestorm.com/) ![654d4f9476ff2a38f37e9ab9_firestorm-homepage-share-img-2](https://github.com/user-attachments/assets/bc1a2c95-b33d-4a2d-af35-4d2d8651d0a2) ## fix 1 - exit confirm popup ![before-exit](https://github.com/user-attachments/assets/8a775ca5-a335-4887-9f79-f96dfcb0f7d2) ![after-exit](https://github.com/user-attachments/assets/8dcfe0fe-bad0-48ba-aa36-68788a996571) ## fix 2 - scaling buttons (also notice new button padding) ![before-scaling](https://github.com/user-attachments/assets/302f1cf7-d9f0-4ad3-811f-63761a84a95a) ![after-scaling](https://github.com/user-attachments/assets/d78ffbde-c24f-4225-bf01-4e28c768951a) ## fix 3 - indoor/outdoor brand image button alignment when no path is selected ![before-brand](https://github.com/user-attachments/assets/eb12ba4c-6e0e-44da-abd9-15bb091c1f3a) ![after-brand](https://github.com/user-attachments/assets/b9fab7a4-1ab8-4151-8e11-b1b1e690b807) ## inspiration for new button padding/sizes - google material design i gave buttons larger left/right padding and minimum sizes in accordance with the Google material design 2 design doc ![Screenshot from 2024-09-06 16-12-02](https://github.com/user-attachments/assets/02ae240f-28c1-4f28-9436-3af79f874d47)

Custom Brand Image Fixes

github.com/mavlink/qgroundcontrol

Custom Brand Image Fixes

mavlink:master ← gillamkid:gillamkid/custom-brand-image

opened 06:54PM - 06 Sep 24 UTC

gillamkid

+21 -8

Description ----------- this PR does 2 things 1. fixes a couple bugs relating… to custom brand images 2. changes brand image used in custom-example to something more appropriate ## Sponsor This contribution was sponsored by [Firestorm](https://www.launchfirestorm.com/) ![654d4f9476ff2a38f37e9ab9_firestorm-homepage-share-img-2](https://github.com/user-attachments/assets/bc1a2c95-b33d-4a2d-af35-4d2d8651d0a2) ## Brand Image Bug 1 ![before-bug-dark](https://github.com/user-attachments/assets/4687c556-2a2e-45a1-bd7b-51d0947983dd) ## Brand Image Bug 2 ![before-outdoor-bug](https://github.com/user-attachments/assets/c2cdd1df-d0b4-48fd-825b-484155f00869) ## Custom Brand Image before ![before-no-bug-indoor](https://github.com/user-attachments/assets/e0ca577e-eeb9-4575-b3d7-e379dbe57e39) ## Custom Brand Image After (indoor) ![after-dark](https://github.com/user-attachments/assets/a320c115-f24f-4e49-a278-2f803e673005) ## Custom Brand Image After (outdoor) ![after-outdoor](https://github.com/user-attachments/assets/7dd7058c-0a30-4e5f-b07c-49dca3c09ee7)

Fix QGC icon (bloated Q)

github.com/mavlink/qgroundcontrol

Fix QGC icon (bloated Q)

mavlink:master ← gillamkid:gillamkid/fix-bloated-icon

opened 03:46PM - 04 Sep 24 UTC

gillamkid

+34 -59

# Description The QGC icon shown in the top left corner of the app did not matc…h the typical QGC icon seen everywhere else (icon of QGC shortcut made after an install, icon branding on QGC website, etc). I replaced the instances of the extra-bloated Q with the more common QGC icon ## Sponsor This contribution was sponsored by [Firestorm](https://www.launchfirestorm.com/) ![654d4f9476ff2a38f37e9ab9_firestorm-homepage-share-img-2](https://github.com/user-attachments/assets/bc1a2c95-b33d-4a2d-af35-4d2d8651d0a2) ## Before/After (icon in app) ![before-icon-in-app](https://github.com/user-attachments/assets/5a7909da-6448-495c-b98a-fcb6c2750a8a) ![after-icon-in-app](https://github.com/user-attachments/assets/ffd4defb-40ef-46fb-8fcd-d9385df007a7) ## Before/After (icon in svg editor view to show outline change) ![before-qgc-icon](https://github.com/user-attachments/assets/dd96e551-b9d4-4754-b8f3-26c69199f5ba) ![after-qgc-icon](https://github.com/user-attachments/assets/bc954004-2d58-42f3-9d05-caac775c0ba8)

Topic		Replies	Views
PX4 Sync / Q&A: Sep 18, 2024 PX4 Autopilot	9	274	November 8, 2024
PX4 Dev Call: March 11, 2020 PX4 Autopilot	0	885	March 4, 2020
PX4 Sync / Q&A: May 22, 2024 PX4 Autopilot	0	202	May 22, 2024
PX4 Dev Call: March 04, 2020 PX4 Autopilot	0	684	February 26, 2020
PX4 Dev Call: March 23, 2022 PX4 Autopilot	0	618	March 16, 2022

PX4 Sync / Q&A: Sep 11, 2024

Related topics