PX4 Sync / Q&A: July 17, 2024

farhang · July 17, 2024, 2:33pm

PX4 Sync / Q&A: July 17, 2024

Agenda

Announcements
Release Discussion
Q&A

Announcements

Release Discussion

github.com/PX4/PX4-Autopilot

Fix CI errors on 1.15 release branch

PX4:release/1.15 ← PX4:1.15-fix-ci

opened 11:23AM - 15 Jul 24 UTC

MaEtUgR

+2 -2

### Solved Problem When checking CI of the `release/1.15` branch I found that s…ome backports are certainly missing: ![image](https://github.com/user-attachments/assets/74213106-dee7-433b-8075-fd7b79c5edd7) https://github.com/PX4/PX4-Autopilot/pull/23198 ![image](https://github.com/user-attachments/assets/64de1828-7c6a-4d08-88d4-c273ef8379f1) https://github.com/PX4/PX4-Autopilot/commit/f726c0e187e0c1dc2b019fa6b4c28b970fd5f45f from https://github.com/PX4/PX4-Autopilot/pull/23265 ### Changelog Entry For release notes: ``` Fix CI errors on 1.15 release branch ``` ### Test coverage Let's see if that's everything for now.

github.com/PX4/PX4-Autopilot

[1.15] Fix: Save flash by not inlining SubscriptionInterval::copy()

PX4:release/1.15 ← PX4:maetugr/fix-subscription-interval-flash-usage-1.15

opened 09:21AM - 15 Jul 24 UTC

MaEtUgR

+81 -35

### Solved Problem Flash problems after https://github.com/PX4/PX4-Autopilot/pu…ll/23392 ### Solution 1:1 port of https://github.com/PX4/PX4-Autopilot/pull/23395 ### Changelog Entry For release notes: ``` Fix: Save flash memory by not inlining SubscriptionInterval::copy() ``` ### Test coverage Tested on main, see https://github.com/PX4/PX4-Autopilot/pull/23395#issuecomment-2225884685

github.com/PX4/PX4-Autopilot

[1.15] Bugfix: Timestamp wrapping when initializing SubscriptionInterval less than the interval time after boot

PX4:release/1.15 ← PX4:maetugr/fix-subscription-interval-timestamp-1.15

opened 02:25PM - 11 Jul 24 UTC

MaEtUgR

+11 -3

1:1 backport of https://github.com/PX4/PX4-Autopilot/pull/23384 after varifying …the problem is present on the 1.15 release. I also successfully checked the SITL test documented in https://github.com/PX4/PX4-Autopilot/issues/23378 and it works with the fix.

Q&A

How to contribute to PX4 code base?
Creating a pull request from a fork - GitHub Docs
PX4-Autopilot/CONTRIBUTING.md at main · PX4/PX4-Autopilot · GitHub

Review needed

Squashed to have a clean merge:

github.com/PX4/PX4-Autopilot

GPS(septentrio) : 1.15-compatible extracted septentrio driver, with new features and fixes

PX4:release/1.15 ← flyingthingsintothings:septentrio-features

opened 01:58PM - 10 Jul 24 UTC

chiara-septentrio

+4036 -136

### Solved Problem The Septentrio driver has been rearranged and has had new features and fixes implemented, all of which were merged to main. This pull request aims to integrate these changes the 1.15 release. The following changes were previously made: -Septentrio driver has been put into a separate module -Add parameters for flexible logging -Fixed automatic setup for septentrio receivers -Add baudrate option and automatic detection -Add automatic detection for ports -Add support for dual receiver ### Solution / ### Changelog Entry For release notes: ``` Feature/Bugfix Clean-up of the septentrio drivers and addition of new features for automatic setup, logging and dual receivers ``` ### Alternatives / ### Test coverage *Tested all the features after updating to 1.15 branch with Septentrio receiver and CubeOrangePlus ### Context Previous pull requests : **[merged]** New features : [#22904](https://github.com/PX4/PX4-Autopilot/pull/22904) **[merged]** Fixes after testing: [23309](https://github.com/PX4/PX4-Autopilot/pull/23309)

github.com/PX4/PX4-Autopilot

Add check for missing or duplicate newlines at the end of files

PX4:main ← PX4:maetugr/fix-newlines

opened 12:43PM - 22 May 24 UTC

MaEtUgR

+300 -588

### Solved Problem When checking changes I realized people do commit missing or… duplicate newlines every now and then. This seems like a non-issue and only leads to problems later on when some tooling doesn't work because the files are not POSIX compliant or whitespace checks fail in the middle of a merge. Manual passes like https://github.com/PX4/PX4-Autopilot/pull/22476 end up not enforcing the rules. ### Solution - Add an automatic check for one single newline at the end of every file that is checked into the repository. ### Changelog Entry ``` Style: Automate enforcing one single newline at the end of each file ``` ### Alternatives Ideally, this would also run through with `make format` but I don't add it because I feel it adds too much delay and hence prolongs the pre-commit hook. Better to have it ran in CI than not at all but maybe someone knows how to make the check more efficient such that the runtime is insignificant during commits. ### Test coverage I tested locally that it triggers with: - All the existing missing newlines and duplicate newlines - Just one of the two checks - Just one duplicate newline in a file ### Context Inspiration: 1. https://stackoverflow.com/a/54348931 1. https://stackoverflow.com/a/31829703/6326048