Multi-device vs. separate driver module - community preference/standards?

PX4 Autopilot
1

I’m looking to add support for the LPS22HH barometer. Its interface is very similar to the LPS22HB, and I was able to easily fork the existing driver to add support (only needed to change the device ID and I2C address).

For contributing this driver, is there an established preference for adding this as a new driver module or extending the existing LPS22HH with another argument to specify the variant?

I’ve occasionally seen this multi-device pattern with devices like the ICM42688/6. However, it seems quite rare so I’d appreciate input from the community on which direction is preferred.

2

Use the same driver and probe for both. The HB is higher accuracy part, so you’ll probably have to do more than just the I2C addr and WHO_AM_I? We’re tight on flash so it’s important to reuse drivers for similar parts like this.

3

I appreciate the feedback here, and I didn’t fully appreciate the flash limitations as I’m using a V6XRT based system. I’ll plan to proceed with integrating the changes I’ve made into the HH driver.